aws-cloudformation / aws-cloudformation/cloudformation-coverage-roadmap

AWS::Cognito:UserPoolRiskConfigurationAttachment - [BUG] - inconsistent validation for ClientId property

Open Beginner friendly
#2,491 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
No language data
Stars
1.1k
Forks
62
PR merge metrics
No merged PRs in 30d

Description

### Name of the resource

AWS::Cognito::UserPoolRiskConfigurationAttachment

### Resource Name

_No response_

### Issue Description

Your documentation [here](https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-resource-cognito-userpoolriskconfigurationattachment.html#cfn-cognito-userpoolriskconfigurationattachment-clientid) says that the ClientId property is optional in its description which reads as follows:

"The app client where this configuration is applied. When this parameter isn't present, the risk configuration applies to all user pool app clients that don't have client-level settings.".

However, the property is marked as "Required: Yes" and the validation ensures it is non-empty.

### Expected Behavior

Assuming the description is correct, this field should be Required: No

### Observed Behavior

this field is marked as Required: Yes

### Test Cases

I think this is fairly obvious from the description

### Other Details

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by comparing the AWS::Cognito::UserPoolRiskConfigurationAttachment documentation for ClientId with the resource's Required setting and non-empty validation. Confirm which behavior matches the documented optional semantics, then update the relevant resource definition or documentation so the requirement and validation agree.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws
Domain
cloud
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.