aws-cloudformation / aws-cloudformation/cloudformation-coverage-roadmap
[Resource Type] - [BUG] - `AWS::DataZone::DataSource` cannot be updated with CloudControl
- Dominant language
- No language data
- Stars
- 1.1k
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
### Name of the resource
AWS::DataZone::DataSource
### Resource Name
_No response_
### Issue Description
`AWS::DataZone::DataSource` resources cannot be updated using CloudControl.
Update requests fail with the following error message:
```
An error occurred (ValidationException) when calling the UpdateResource operation: Model validation failed (#: required key [DomainIdentifier] not found
#: required key [ProjectIdentifier] not found
#: required key [EnvironmentIdentifier] not found)
```
Including those properties in the patch document does not work either because they're `createOnlyProperties`, it yields the following error message:
```
An error occurred (NotUpdatableException) when calling the UpdateResource operation: Invalid patch update: createOnlyProperties [/properties/EnvironmentIdentifier, /properties/DomainIdentifier, /properties/ProjectIdentifier] cannot be updated
```.
### Expected Behavior
`AWS::DataZone::DataSource` resources can be updated.
### Observed Behavior
CloudControl does not handle the `createOnlyProperties`.
### Test Cases
Create a `AWS::DataZone::DataSource` resource and then issue an arbitrary `update-resource` API call for it (e.g. adding another database).
For example:
```sh
aws cloudcontrol update-resource --type-name AWS::DataZone::DataSource --identifier "dzd_b8pyj689jp5ez4|4uaba1iqcl613k" \
--patch-document '[
{
"op": "add",
"path": "/Configuration",
"value": {
"GlueRunConfiguration": {
"RelationalFilterConfigurations": [
{
"DatabaseName": "my-test-db-3"
},
{
"DatabaseName": "my-test-db-4"
}
]
}
}
}
]'
```
### Other Details
_No response_
Contributor guide
Research direction
Start with the AWS CloudControl `update-resource` API and reproduce the documented `AWS::DataZone::DataSource` update using the example CLI command and patch document. Compare the validation and `NotUpdatableException` responses when the create-only properties are omitted or included; done means arbitrary updates succeed without requiring or attempting to modify those properties.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100