aws-cloudformation / aws-cloudformation/cloudformation-coverage-roadmap

DMS ReplicationInstance propagated tags do not update

Open
#1,845 0 comments 2 reactions 0 assignees View on GitHub
bug NeedTriage
Dominant language
No language data
Stars
1.1k
Forks
62
PR merge metrics
No merged PRs in 30d

Description

### Name of the resource

AWS::DMS::ReplicationInstance

### Resource Name

_No response_

### Issue Description

Thanks to https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/1252 DMS replication instances now get tags when they are created -- but changing tag keys and values in the stack do not propagate the updates to the replication instances.

### Expected Behavior

CloudFormation stack tag updates should propagate to all resources that are tagged BY cloudformation in the first place.

### Observed Behavior

Changing a tag key results in no change to the replication instance tags
Deleting a tag key results in no change to the replication instance tags
Adding a new tag key to an already-tagged instance results in no change to the replication instance tags

### Test Cases

* Create a minimal replication instance in a template with a single tag defined at the command-line in CloudFormation: `aws cloudformation deploy --template-file template.yml --stack-name replication-instances --tags mytag:testing=something`
* Update the stack with a different tag key and/or value: `aws cloudformation deploy --template-file template.yml --stack-name replication-instances --tags mytag:othertag=banana`

After the stack update, the tags have not changed: the new tag is not present, and the old tag is still there, even though the stack-level tags have changed

Adding a tag directly to the resource in the template and updating the stack DOES result in the in-template tag being applied, but command-line supplied tags are NOT applied after the initial creation.

Changing the tag directly on the resource in the template DOES result in the applied tag being changed, but again command-line supplied tags are NOT applied.

### Other Details

```yaml
AWSTemplateFormatVersion: 2010-09-09
Description: Replicate DMS Instance tagging failure

Resources:
Instance:
Type: AWS::DMS::ReplicationInstance
Properties:
ReplicationInstanceClass: dms.t2.micro
```

Contributor guide

Open the contributing guide

Research direction

Start with the minimal template.yml scenario and run the two `aws cloudformation deploy` commands described in the issue, inspecting the ReplicationInstance tags after each update. Done means command-line stack tag additions, changes, and deletions propagate to the AWS::DMS::ReplicationInstance without leaving obsolete tags.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws
Domain
cloud
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.