aws-cloudformation / aws-cloudformation/cloudformation-cli

Project should use modern python packaging techniques

Open
#1,083 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
336
Forks
172
Avg merge
3d 5m
Merged PRs (30d)
3

Description

Hello 👋🏻

I notice this repo still uses `setup.py` and has some potentially outdated config for modern python packaging. As far as I can tell it should be pretty easy to port to `pyproject.toml` using [PEP621](https://peps.python.org/pep-0621/) and using the new [PEP517](https://peps.python.org/pep-0517/) and [PEP518](https://peps.python.org/pep-0518/) standards. There are no C extensions to build for instance.

In addition, the project might benefit from some of the more modern python toolset i.e.:

- [Ruff](https://docs.astral.sh/ruff/) for linting over pylint
- Introducing gradual typing with e.g. [MyPy](https://www.mypy-lang.org/)
- A modern package manager such as [pdm](https://pdm-project.org/en/latest/) or [poetry](https://python-poetry.org/)

I'd be happy to submit a PR implementing some or all of the above depending on what you do/don't want to be included. I'd suggest the move to storing metadata in `pyproject.toml` and using the new packaging/build techniques as a minimum

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.