aws-cloudformation / aws-cloudformation/cloudformation-cli-go-plugin

[Question] Is encoding.Stringify required?

Open
#227 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
53
Forks
31
PR merge metrics
No merged PRs in 30d

Description

I'm curious if use of `encoding.Stringify` is actually required.

I was having issues with contract tests failing due to Request/Response not matching. Digging into that issue I found several bugs in Stringify:
- integers quoted in the Response
- nested structs not honoring the `omitempty` tag

As a work around I commented out the use of Stringify in `cfn.newResponse` and everything works- that leads me to wonder why Stringify exists.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.