aws-cloudformation / aws-cloudformation/cloudformation-cli-go-plugin

Include json tags for the name of the field

Open
#184 5 comments 0 reactions 0 assignees View on GitHub
Researching
Dominant language
Go
Stars
53
Forks
31
PR merge metrics
No merged PRs in 30d

Description

https://github.com/aws-cloudformation/cloudformation-cli-go-plugin/blob/f7249d18d5feaa31e50b0bd108528510b4d72f6e/python/rpdk/go/templates/types.go.tple#L15

As the provided regex below supports lower case letters we should include the json name tags.
https://github.com/aws-cloudformation/cloudformation-cli/blob/04ead469a37db6d0efdb357d8fa66fd84e0f1c09/src/rpdk/core/data/schema/provider.definition.schema.v1.json#L316

Also it will help if we are going to rename it in the struct `{{ name|uppercase_first_letter }}`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.