aws-amplify / aws-amplify/amplify-hosting

Build notices have incorrect deploy URL

Open
#739 11 comments 0 reactions 0 assignees View on GitHub
archived bug pending-prioritization
Dominant language
Dockerfile
Stars
481
Forks
123
PR merge metrics
No merged PRs in 30d

Description

For feature branch continuous deploys, the build notices we get for these have the wrong URL in them. The console has the correct URL, where the slash in "feature/branchname" is converted to a dash, but the deploy notice emails keep the slash, and thus the URL is wrong. Here's an example of the email we get:

```
"Build notification from the AWS Amplify Console for app: https://feature/skeletal-html.changedforsecurity.amplifyapp.com/. Your build status is SUCCEED. Go to https://console.aws.amazon.com/amplify/home?region=us-east-2#changedforsecurity/feature/skeletal-html/1 to view details on your build. "
```

And the correct URL (as shown in the Amplify console) would be: https://feature-skeletal-html.changedforsecurity.amplifyapp.com/

Also, the quotes around that text in the email seem unnecessary :)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing a feature-branch continuous deploy and compare the deploy notice email with the URL shown in the AWS Amplify Console. Verify the branch slash is converted to a dash in the application URL and check whether the surrounding quotation marks are still present. Done means the email contains the same working deploy URL as the console and no unnecessary quotes.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws
Domain
ci-cd, cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.