aws-amplify / aws-amplify/amplify-hosting
Feature request: Use custom domain in PR comment for preview link
- Dominant language
- Dockerfile
- Stars
- 481
- Forks
- 123
- PR merge metrics
- No merged PRs in 30d
Description
**Is your feature request related to a problem? Please describe.**
When a PR is created, the AWS Amplify GitHub bot comments the preview URL, as added in #264. This is great, except that we are using a custom domain.
So the comment mentions `https://pr-{PR}.{APP_ID}.amplifyapp.com`, while it should be `https://pr-{PR}.example.com`.
This is important for us because our app does not work on the amplifyapp.com domain due to CORS restrictions, so we must use our custom domain.
**Describe the solution you'd like**
Please allow configuring the PR bot to use a custom domain.
Contributor guide
Research direction
Start by locating the AWS Amplify GitHub PR bot implementation and the preview-comment behavior introduced in #264. Trace how the amplifyapp.com preview URL is assembled and how configuration is handled; done means a configured custom domain produces the expected PR preview link in the comment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, github
- Domain
- ci-cd, cloud
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100