aws-amplify / aws-amplify/amplify-data

[FR]: re-introduce lockfile verification post yarn migration

Open
#691 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
18
Forks
23
Avg merge
26m
Merged PRs (30d)
1

Description

### Issue
While still using NPM as package manager, the package-lock was validated to not contain localhost as package host.
During Yarn v4 migration (https://github.com/aws-amplify/amplify-data/pull/690), this check has been disabled since there is no `package-lock.json` file anymore.

Reintroduce that check

### Desired Outcome
- there is a script checking the `yarn.lock` for localhost references (because verdaccio)
- the script also checks for correct types (if necessary)
- the script is run as part of PR checks

Contributor guide

Open the contributing guide

Research direction

Review the Yarn v4 migration in pull request #690 and inspect yarn.lock plus the repository's existing PR-check configuration. Identify where the former package-lock validation lived, then define the lockfile checks for localhost references and any required types. Done means the check runs as part of PR checks and rejects invalid yarn.lock content.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.