aws-amplify / aws-amplify/amplify-cli

Describe the version of node contributors should use in CONTRIBUTING.md

Open
#8,407 0 comments 0 reactions 0 assignees View on GitHub
feature-request p3 platform
Dominant language
TypeScript
Stars
2.9k
Forks
825
Avg merge
11d 23h
Merged PRs (30d)
2

Description

### Is this related to a new or existing Amplify category?

New category

### Is this related to another service?

_No response_

### Describe the feature you'd like to request

Currently, CONTRIBUTING.md does not specify which version of node should be used by Amplify-CLI contributors.
This led to the following problems.

## OS
macOS

## 1. [node v15.0.0 ~ ]
When I commit the changes, hooks will test them, but some tests will fail due to `Call retries were exceeded`.

スクリーンショット 2021-10-09 17 09 28

## 2. [node v 16.0.0 ~]
Using nodev16, I got some error while running `yarn setup-dev`.
It caused by`node-pty-prebuilt-multiarch`
```
$ yarn dev-build && yarn rm-dev-link && yarn link-dev && yarn rm-aa-dev-link && yarn link-aa-dev
$ yarn --cache-folder ~/.cache/yarn && lerna run build
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
warning amplify-app@3.0.14: The engine "@aws-amplify/cli" appears to be invalid.
[3/4] 🔗 Linking dependencies...
warning " > @commitlint/cz-commitlint@12.1.4" has unmet peer dependency "inquirer@^8.0.0".
warning " > babel-loader@8.2.2" has unmet peer dependency "webpack@>=2".
warning " > amplify-codegen-appsync-model-plugin@1.22.4" has unmet peer dependency "graphql@^14.5.8".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-codebuild@1.124.0" has unmet peer dependency "@aws-cdk/aws-codecommit@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-codebuild@1.124.0" has unmet peer dependency "@aws-cdk/aws-codestarnotifications@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-codepipeline@1.124.0" has unmet peer dependency "@aws-cdk/aws-codestarnotifications@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-codepipeline-actions@1.124.0" has unmet peer dependency "@aws-cdk/aws-codecommit@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-codepipeline-actions@1.124.0" has unmet peer dependency "@aws-cdk/aws-codedeploy@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-codepipeline-actions@1.124.0" has unmet peer dependency "@aws-cdk/aws-events-targets@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-codepipeline-actions@1.124.0" has unmet peer dependency "@aws-cdk/aws-stepfunctions@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-lambda@1.124.0" has unmet peer dependency "@aws-cdk/aws-signer@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-route53-targets@1.124.0" has unmet peer dependency "@aws-cdk/aws-globalaccelerator@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-category-api > @aws-cdk/aws-sns@1.124.0" has unmet peer dependency "@aws-cdk/aws-codestarnotifications@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-codegen-appsync-model-plugin > @graphql-codegen/testing@1.17.7" has unmet peer dependency "jest-diff@^23.0.0 || ^24.0.0 || ^25.0.0 || ^26.0.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-e2e-tests > aws-appsync@4.1.1" has unmet peer dependency "@react-native-community/async-storage@^1.11.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-e2e-tests > aws-appsync@4.1.1" has unmet peer dependency "@react-native-community/netinfo@^5.0.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-e2e-tests > graphql-tag@2.12.5" has unmet peer dependency "graphql@^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-frontend-android > graphql-config@2.2.2" has unmet peer dependency "graphql@^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > @testing-library/user-event@12.8.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql@1.4.2" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql@1.4.2" has incorrect peer dependency "react@^16.8.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql@1.4.2" has incorrect peer dependency "react-dom@^16.8.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql-explorer@0.6.3" has incorrect peer dependency "react@^15.6.0 || ^16.0.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql-explorer@0.6.3" has incorrect peer dependency "react-dom@^15.6.0 || ^16.0.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-function-transformer > @aws-cdk/assert@1.124.0" has unmet peer dependency "constructs@^3.3.69".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-cognito@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-ec2@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-elasticsearch@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-iam@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-lambda@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-s3-assets@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-rds@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "@aws-cdk/aws-secretsmanager@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-appsync@1.124.0" has unmet peer dependency "constructs@^3.3.69".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "@aws-cdk/aws-applicationautoscaling@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "@aws-cdk/aws-cloudwatch@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "@aws-cdk/aws-iam@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "@aws-cdk/aws-kinesis@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "@aws-cdk/aws-kms@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "@aws-cdk/aws-lambda@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "@aws-cdk/custom-resources@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-index-transformer > @aws-cdk/aws-dynamodb@1.124.0" has unmet peer dependency "constructs@^3.3.69".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "@aws-cdk/aws-certificatemanager@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "@aws-cdk/aws-cloudwatch@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "@aws-cdk/aws-kms@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "@aws-cdk/aws-logs@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "@aws-cdk/aws-route53@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "@aws-cdk/aws-secretsmanager@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "@aws-cdk/custom-resources@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-searchable-transformer > @aws-cdk/aws-elasticsearch@1.124.0" has unmet peer dependency "constructs@^3.3.69".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > @aws-amplify/graphql-transformer-interfaces > @aws-cdk/aws-rds@1.124.0" has unmet peer dependency "@aws-cdk/cx-api@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-provider-awscloudformation > @aws-cdk/aws-batch@1.124.0" has unmet peer dependency "@aws-cdk/aws-ssm@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-provider-awscloudformation > @aws-cdk/aws-codecommit@1.124.0" has unmet peer dependency "@aws-cdk/aws-codestarnotifications@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-provider-awscloudformation > @aws-cdk/aws-events-targets@1.124.0" has unmet peer dependency "@aws-cdk/aws-apigateway@1.124.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > graphql-transformers-e2e-tests > @aws-amplify/core@2.3.0" has unmet peer dependency "@react-native-community/netinfo@^5.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-frontend-android > graphql-config > graphql-import@0.7.1" has unmet peer dependency "graphql@^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql > @graphiql/toolkit@0.2.2" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql > codemirror-graphql@1.0.2" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql > graphql-language-service@3.1.4" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-util-mock > aws-appsync > apollo-link-http@1.3.1" has incorrect peer dependency "graphql@^0.11.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql > codemirror-graphql > graphql-language-service-interface@2.8.4" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql > codemirror-graphql > graphql-language-service-parser@1.9.2" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql > graphql-language-service > graphql-language-service-types@1.8.2" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-graphiql-explorer > graphiql > codemirror-graphql > graphql-language-service-interface > graphql-language-service-utils@2.5.3" has incorrect peer dependency "graphql@>= v14.5.0 <= 15.5.0".
warning "workspace-aggregator-dcf25ae2-4feb-48a3-881d-21f50b7c19cc > amplify-e2e-tests > aws-amplify > @aws-amplify/analytics > @aws-sdk/client-firehose > @aws-sdk/middleware-retry > react-native-get-random-values@1.7.0" has unmet peer dependency "react-native@>=0.56".
[4/4] 🔨 Building fresh packages...
[-/13] ⠁ waiting...
[9/13] ⠁ node-pty-prebuilt-multiarch
[-/13] ⠁ waiting...
[-/13] ⠁ waiting...
error /Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/node-pty-prebuilt-multiarch: Command failed.
Exit code: 1
Command: prebuild-install || node scripts/install.js
Arguments:
Directory: /Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/node-pty-prebuilt-multiarch
Output:
prebuild-install WARN install No prebuilt binaries found (target=16.8.0 runtime=node arch=arm64 libc= platform=darwin)
gyp info it worked if it ends with ok
gyp info using node-gyp@7.1.2
gyp info using node@16.8.0 | darwin | arm64
gyp info find Python using Python version 3.9.7 found at "/opt/homebrew/opt/python@3.9/bin/python3.9"
(node:17337) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
(Use `node --trace-deprecation ...` to show where the warning was created)
gyp info spawn /opt/homebrew/opt/python@3.9/bin/python3.9
gyp info spawn args [
gyp info spawn args '/Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/@npmcli/run-script/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/node-pty-prebuilt-multiarch/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/@npmcli/run-script/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/Users/toueyoshiaki/Library/Caches/node-gyp/16.8.0/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/Users/toueyoshiaki/Library/Caches/node-gyp/16.8.0',
gyp info spawn args '-Dnode_gyp_dir=/Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/@npmcli/run-script/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/Users/toueyoshiaki/Library/Caches/node-gyp/16.8.0/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/node-pty-prebuilt-multiarch',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
CXX(target) Release/obj.target/pty/src/unix/pty.o
In file included from ../src/unix/pty.cc:20:
In file included from ../../nan/nan.h:58:
In file included from /Users/toueyoshiaki/Library/Caches/node-gyp/16.8.0/include/node/node.h:63:
In file included from /Users/toueyoshiaki/Library/Caches/node-gyp/16.8.0/include/node/v8.h:30:
/Users/toueyoshiaki/Library/Caches/node-gyp/16.8.0/include/node/v8-internal.h:488:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
!std::is_same>::value>::Perform(data);
~~~~~^~~~~~~~~~~
remove_cv
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:776:50: note: 'remove_cv' declared here
template struct _LIBCPP_TEMPLATE_VIS remove_cv
^
1 error generated.
make: *** [Release/obj.target/pty/src/unix/pty.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/@npmcli/run-script/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack at ChildProcess.emit (node:events:394:28)
gyp ERR! stack at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Darwin 20.6.0
gyp ERR! command "/Users/toueyoshiaki/.nodenv/versions/16.8.0/bin/node" "/Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /Users/toueyoshiaki/Desktop/OSS/amplify-cli/node_modules/node-pty-prebuilt-multiarch

error Command failed with exit code 1.
```

All of these problems could be avoided by using node v14.
So I was thinking of specifying in CONTRIBUTING.md to use node v12 ~ v14.

### Describe the solution you'd like

Describe the version of node contributors should use in CONTRIBUTION.md

### Describe alternatives you've considered

ditto

### Additional context

_No response_

### Is this something that you'd be interested in working on?

- [X] 👋 I may be able to implement this feature request
- [ ] ⚠️ This feature might incur a breaking change

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.