aws-amplify / aws-amplify/amplify-cli

Spinner Text is incorrect for file %

Open
#8,210 0 comments 0 reactions 0 assignees View on GitHub
bug p3 platform platform-push
Dominant language
TypeScript
Stars
2.9k
Forks
825
Avg merge
11d 23h
Merged PRs (30d)
2

Description

### Before opening, please confirm:

- [X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
- [X] I have [searched for duplicate or closed issues](https://github.com/aws-amplify/amplify-cli/issues?q=is%3Aissue+).
- [X] I have read the guide for [submitting bug reports](https://github.com/aws-amplify/amplify-cli/blob/master/CONTRIBUTING.md#bug-reports).
- [X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

### How did you install the Amplify CLI?

npm

### If applicable, what version of Node.js are you using?

latest

### Amplify CLI Version

latest

### What operating system are you using?

Mac

### Amplify Categories

Not applicable

### Amplify Commands

push

### Describe the bug

The spinner says:

Uploading files...33%

Which to me seems to indicate that 33% of the files have been uploaded...but what it is actually showing is the % of the current file being uploaded (assuming that current file is bigger than a certain chunk size...

Therefore the % is almost useless...as it will bounce around...

spinner.text = `Uploading files...${Math.round((max.loaded / max.total) * 100)}%`;

### Expected behavior

This should be changed either to Uploading Files...Current File: 30%

Or we should change it to determine how many files are going to be uploaded and then figure out the % based on that.

### Reproduction steps

Upload lots of big files...

### GraphQL schema(s)

```graphql
# Put schemas below this line

```

### Log output

```
# Put your logs below this line

```

### Additional information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.