aws-amplify / aws-amplify/amplify-cli

OAuth flow could use secrets prompt for AppID & AppSecrets

Open
#5,299 0 comments 0 reactions 0 assignees View on GitHub
auth feature-request p3
Dominant language
TypeScript
Stars
2.9k
Forks
825
Avg merge
11d 23h
Merged PRs (30d)
2

Description

**Describe the bug**

currently when we prompt for secrets, we display them:

![image](https://user-images.githubusercontent.com/6764957/92782939-f577aa80-f3d7-11ea-94b8-9a789cfff2a9.png)

**Amplify CLI Version**
You can use `amplify -v` to check the amplify cli version on your system

v 4.28

**To Reproduce**

`amplify add auth`

**Expected behavior**

show `******` or blank for secrets. this is a built in feature to inquirer/enquirer that we dont use because of the way we set it up in https://github.com/aws-amplify/amplify-cli/blob/4e5f5c62287252ff59ecda050390e9b3c2b00146/packages/amplify-category-auth/src/provider-utils/supported-services.ts. however it should just take a couple small tweaks to do.

**note**

we should scan thru the rest of the cli for other incidences of this pattern

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.