aws-amplify / aws-amplify/amplify-cli
Add emailConfiguration support to Cognito cli-inputs.json
- Dominant language
- TypeScript
- Stars
- 2.9k
- Forks
- 825
- Avg merge
- 11d 23h
- Merged PRs (30d)
- 2
Description
### Is this feature request related to a new or existing Amplify category?
auth
### Is this related to another service?
_No response_
### Describe the feature you'd like to request
I added `emailConfiguration` with `emailSendingAccount` and `sourceArn` properties in `cli-inputs.json` `cognitoConfig`, but I found that it wouldn't update the Cognito user pool.
Then I searched a lot online, went through the docs and the codebase, but I didn't find any support for `emailConfiguration` in `cli-inputs.json`.
### Describe the solution you'd like
Is there any problem with exposing my `AWS::AccountId` in `override.ts`?
Or any better way I could put `sourceArn` in `override.ts` without exposing my `AWS::AccountId`?
Alternatively, could you add support for `emailConfiguration` in `cli-inputs.json`?
I think this could be implemented inside `packages/amplify-category-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.ts:210`. (could be wrong)
### Describe alternatives you've considered
I am now adding `userPool.emailConfiguration` to `override.ts`.
### Additional context
_No response_
### Is this something that you'd be interested in working on?
- [X] 👋 I may be able to implement this feature request
### Would this feature include a breaking change?
- [ ] ⚠️ This feature might incur a breaking change
Contributor guide
Research direction
Start at packages/amplify-category-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.ts around line 210 and trace how cognitoConfig from cli-inputs.json reaches the user pool. Compare the existing configuration handling with emailConfiguration, then verify that emailSendingAccount and sourceArn are applied without requiring override.ts; the issue is done when a CLI-defined configuration updates the Cognito user pool.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, typescript
- Domain
- authentication, cli, cloud
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100