avast / avast/retdec

Fileinfo is slow: section hashes

Open
#157 2 comments 0 reactions 0 assignees View on GitHub
C-fileinfo enhancement P-run T-format-pe
Dominant language
C++
Stars
8.6k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

Fileinfo takes too much time to analyze these files:
- [2809a2044803fd55e393723b9ad2d19e808074424dad56beabb9816e3df1fc60](https://www.virustotal.com/en/file/2809a2044803fd55e393723b9ad2d19e808074424dad56beabb9816e3df1fc60/analysis/)
- [e2c686e113991ab835d6ee92c570d0db0d6c9284fdeeced7fbf041cac35ed31c](https://www.virustotal.com/en/file/e2c686e113991ab835d6ee92c570d0db0d6c9284fdeeced7fbf041cac35ed31c/analysis/)
- [859b73bfd1338e4d7b31544a99e748ba10b8dcdf9cd7ae45a38498a99888678a](https://www.virustotal.com/en/file/859b73bfd1338e4d7b31544a99e748ba10b8dcdf9cd7ae45a38498a99888678a/analysis/)
- [a92ba9c399d2ec512263b46316ee29e55cf6eb25e34c1a7927382823569e1f02](https://www.virustotal.com/en/file/a92ba9c399d2ec512263b46316ee29e55cf6eb25e34c1a7927382823569e1f02/analysis/)
- [b06728751ebbe11172584e568c0c189859b927b42ba0af620a556f454764b18a](https://www.virustotal.com/en/file/b06728751ebbe11172584e568c0c189859b927b42ba0af620a556f454764b18a/analysis/)

Log from callgrind for the first file (`2809a20...`) shows that most of the time is spent computing section hashes: ![4d3b5d97834f3f48b4b43eb0ccbaeeaa callgrind](https://user-images.githubusercontent.com/20342097/35866453-8ad62870-0b57-11e8-93af-fc356154c624.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce Fileinfo analysis on the five VirusTotal samples listed in the issue and inspect the provided callgrind result, focusing on section-hash computation. The issue names no source files, tests, benchmark target, or specific optimization, so completion would need an agreed measure showing that analysis time is reduced.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance, reverse-engineering, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.