avast / avast/retdec

Migrate hardcoded make to ${CMAKE_MAKE_PROGRAM}

Open
#1,056 0 comments 0 reactions 0 assignees View on GitHub
C-build-system
Dominant language
C++
Stars
8.6k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

This issue reflects the reverted commit 085666b6340655904484aff83c1db28c83a37067. We use hard-coded make in our cmake when building Yara. Currently, when we replace the hard-coded make with ` ${CMAKE_MAKE_PROGRAM}` our TC linux-debug build fails on:

```
FAILED: deps/yara/yara/src/yara-stamp/yara-build deps/install/yara/lib/libyara.a
16:54:05 cd /home/tcagent/work/c1867d72f67fc407/retdec/build/deps/yara/yara/src/yara && /usr/bin/ninja clean && /usr/bin/ninja -j8 && /usr/bin/cmake -E touch /home/tcagent/work/c1867d72f67fc407/retdec/build/deps/yara/yara/src/yara-stamp/yara-build
16:54:05 ninja: error: loading 'build.ninja': No such file or directory
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the CMake build definition for the Yara dependency and reproduce the TC linux-debug failure, focusing on the generated Yara build directory and the recorded ninja commands. Done means the build uses CMAKE_MAKE_PROGRAM without losing build.ninja and the TC linux-debug build completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.