avast / avast/pe_tools

RuntimeError: version info string is not terminated by zero

Open
#10 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
69
Forks
15
PR merge metrics
No merged PRs in 30d

Description

In the version info parser ([this line](https://github.com/avast/pe_tools/blob/master/pe_tools/version_info.py#L235)), it seems that it is not possible for a file to have the last number on the version be anything other than zero, and I was wondering why is that a problem?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at pe_tools/version_info.py:235 and trace how the version info parser validates the final version number. Reproduce the RuntimeError with a PE file whose final version number is nonzero, then determine the expected behavior from the parser and PE version-info format. Done means the behavior is explained and, if incorrect, covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
operating-systems, reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.