auto-ssl / auto-ssl/lua-resty-auto-ssl

Change log level when chmod fails ?

Open
#114 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Lua
Stars
2k
Forks
184
PR merge metrics
No merged PRs in 30d

Description

Hi,

we have a kind of restricted nginx setup (non root both master and workers), so lua-resty-auto-ssl fails chmoding (though) the permissions are ok, and everything works):

`nginx: [error] [lua] init_master.lua:56: generate_config(): auto-ssl: failed to create letsencrypt dir permissions: Executing command failed: chmod 777 /etc/resty-auto-ssl/letsencrypt: chmod: /etc/resty-auto-ssl/letsencrypt: Operation not permitted`

IMHO this could be changed to warn only:

- 777 is a bit of overkill (but I understand the simplicity)
- If this failed, it does not mean that lets encrypt will actually fail

Would you accept a simple PR? Or you think that it's ok as it is?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at init_master.lua:56 in generate_config() and inspect how the failed chmod is logged. Reproduce the restricted nginx setup if possible, then confirm that a chmod failure is reported at warning level while the rest of configuration generation continues as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua, nginx
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.