authorjapps / authorjapps/zerocode

[1.3.28] Step "assertions" field is not null safe

Open
#507 6 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
1k
Forks
453
Avg merge
7d 2h
Merged PRs (30d)
5

Description

Is it possible to make Step.assertions field null safe ?
We're using tests on spring boot and with version changed from 2.5.4 to 2.6.1 we're receiving NPE on Step constructor.
JsonNode assertions was previously always not null - now it's null.

this.assertions = **assertions**.isNull() ? verify : assertions;

Contributor guide

Open the contributing guide

Research direction

Start at the Step constructor, where the assertions JsonNode is dereferenced, and reproduce the failure with Spring Boot 2.6.1. Done means constructing a Step with null assertions no longer raises an NPE while the existing non-null behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.