authgear / authgear/authgear-server

Sanitize "state" in the audit log for `user.created` and `user.authenticated`

Open
#3,456 0 comments 0 reactions 0 assignees View on GitHub
cooldown/minor-feature
Dominant language
Go
Stars
2k
Forks
125
Avg merge
2d 17h
Merged PRs (30d)
32

Description

Re: https://github.com/authgear/authgear-server/issues/3443#issuecomment-1792131763

In #3443 we made "state" in oauth available for `user.created` and user.authenticated` webhooks.
This also makes the param appears in the corresponding audit logs.

If users uses state param to transport PII, the info may be retained in the audit log, which may be a small privacy concern. We may discuss if the state is needed in the audit log.

Contributor guide

Open the contributing guide

Research direction

Start by reading issue #3443 and its linked implementation of the state parameter for the user.created and user.authenticated webhooks. Trace how that value reaches the corresponding audit logs, then determine the intended sanitization or removal behavior; done means user-supplied state is no longer retained there.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.