authgear / authgear/authgear-server

Improve identity not found error message when email and oauth conflicted in login

Open
#2,676 0 comments 0 reactions 0 assignees View on GitHub
bug/minor
Dominant language
Go
Stars
2k
Forks
125
Avg merge
2d 17h
Merged PRs (30d)
32

Description

Similar to https://github.com/authgear/authgear-server/issues/1856 ,
But for login.

Now when user signed up with Google, and then try to **login** with email address,
They will see the error message "This identity cannot be found. Please ensure it is correct." which is not helpful in guiding them to login with Google instead.

It also differs from what they see in the signup page: "This email is associated with an account. Do you want to sign in with Google?"

**Changes**

- Signed up with google then email login: `This email is associated with an account. Do you want to sign in with Google?`
- Signed up with email then google login: `Unable to log in with Google. Do you want to log in with email?`

**Rabbit-hole**

In the future, we should allow it to be disabled for security concern. If disabled, Authgear will not attempt to match the identities across email and 3rd party oauth providers.

**No-go**

- No need to implement Auto-merge: https://github.com/authgear/authgear-server/issues/261

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Start by tracing the login flow for the “identity cannot be found” response and compare it with the signup handling described in the issue; done means the two conflicting login cases produce the specified guidance without implementing auto-merge or the future security setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.