aurelia / aurelia/webpack-plugin
InlineViewDependenciesPlugin doesn't suport 2nd and 3rd arg
- Dominant language
- TypeScript
- Stars
- 89
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
@jods4, the current implementation assumes inlineView only takes 1 arg. But `inlineView` api supports additional 2nd and 3rd args. Given user suppose to use `PLATFORM.moduleName` on 2nd arg. It should be an easy fix for this line to `length >= 1 && length <= 3`. I am too lazy to fork and create PR.
https://github.com/aurelia/webpack-plugin/blob/93f7aff96167c7be752a01edd30f2a08c8bb529d/src/InlineViewDependenciesPlugin.ts#L39
http://aurelia.io/docs/api/templating/function/inlineView
```javascript
inlineView(markup: string, dependencies?: Array, dependencyBaseUrl?: string): any
```
Just point out, I also has suspicion about 3rd arg `dependencyBaseUrl`, it looks like complicating situation of `PLATFORM.moduleName` in 2rd arg.
Contributor guide
Research direction
Read src/InlineViewDependenciesPlugin.ts around line 39 and compare its argument-count handling with inlineView's documented three-argument signature. Confirm how PLATFORM.moduleName in the second argument and dependencyBaseUrl in the third are handled; done when valid one-, two-, and three-argument calls are accepted without breaking the existing case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100