setTimout is evil ;-)
Open
- Dominant language
- TypeScript
- Stars
- 38
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
Can the setTimeout be removed from [here](https://github.com/aurelia/testing/blob/bbef100d01b0c945792508f0847489739945014d/src/component-tester.ts#L82) please?
If this has been replaced with sinon fakeTimers this just causes all manner of problems.
Why is it there and can it be replaced by the aurelia task queue?
Ta,
John
Contributor guide
Research direction
The issue points to src/component-tester.ts#L82; start by inspecting the setTimeout and how tests use sinon fakeTimers or the Aurelia task queue. Done means removing the problematic timeout without breaking component-test timing, with the existing component tests still passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100