aurelia / aurelia/dependency-injection

Bug: The update from 1.5.2 to 1.6.0 is breaking

Open
#229 1 comment 1 reaction 0 assignees View on GitHub
question
Dominant language
TypeScript
Stars
159
Forks
64
PR merge metrics
No merged PRs in 30d

Description

I'm submitting a bug report

Library Version:
1.6.0

Since the update to 1.6.0, some of my unittests(jest) in my project stopped working.

```
Loader must implement loadTemplate(url).
115 | });
116 |
> 117 | await component.create(bootstrap);
| ^
118 | });
129 |
at Loader.loadTemplate (node_modules/aurelia-loader/dist/commonjs/aurelia-loader.js:119:11)
at ensureRegistryEntry (node_modules/aurelia-templating/src/view-engine.ts:22:17)
at ViewEngine.Object..ViewEngine.loadViewFactory (node_modules/aurelia-templating/src/view-engine.ts:135:12)
at ConventionalViewStrategy.Object..ConventionalViewStrategy.loadViewFactory (node_modules/aurelia-templating/src/view-strategy.ts:133:23)
at HtmlBehaviorResource.Object..HtmlBehaviorResource.load (node_modules/aurelia-templating/src/html-behavior.ts:306:10)
at ResourceDescription.Object..ResourceDescription.load (node_modules/aurelia-templating/src/module-analyzer.ts:210:35)
at ResourceModule.Object..ResourceModule.load (node_modules/aurelia-templating/src/module-analyzer.ts:122:23)
at node_modules/aurelia-templating/src/view-engine.ts:288:41
```

Downgrading the version back to 1.5.2 fixes this issue!

Please tell us about your environment:
Operating System:
Linux (Ubuntu 18.04)

Node Version:
14.21.3

Expected/desired behavior:
Update should not contain breaking changes.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the failing Jest unit tests with version 1.6.0 and compare them with 1.5.2. Read the stack trace through aurelia-loader and aurelia-templating, especially Loader.loadTemplate and ViewEngine.loadViewFactory; done means the affected tests pass on 1.6.0 without breaking the documented update behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.