aurelia / aurelia/binding

IE11 - repeat.for with sort value converter not updating component after sort direction changes.

Open
#708 11 comments 0 reactions 0 assignees View on GitHub
documentation help wanted
Dominant language
JavaScript
Stars
110
Forks
98
PR merge metrics
No merged PRs in 30d

Description

**I'm submitting a bug report**

* **Library Version:**
2.0.0

**Please tell us about your environment:**
* **Operating System:**
Windows 10

* **Node Version:**
8.11.3

* **NPM Version:**
6.1.0

* **JSPM OR Webpack AND Version**
Gulp 4

* **Browser:**
IE 11

* **Language:**
TS v2.1.6

**Current behavior:**
repeat.for with sort value converter failing is to update component when a size attribute is present on the select element.

I have a select list sorted by a value converter and two buttons to toggle the sort direction. In IE 11 the select list does not update even though the value converter is being called an my list object is updated.

**The root cause appears to be using the size attribute on the select element**

This is working in all other browsers.

**Expected/desired behavior:**

[Skeleton App Demo](https://github.com/Ra-Sedgwick/aurelia-select-bug)

* **What is the expected behavior?**
The select lists sort direction changes when either button is pressed.

* **What is the motivation / use case for changing the behavior?**
Cross browser compatibility.

Contributor guide

Open the contributing guide

Research direction

Start with the linked Skeleton App Demo and reproduce the repeat.for sorting problem in IE11, focusing on a select element with a size attribute and a sort value converter. Trace the binding update from the sort-direction buttons and compare it with other browsers. Done means the select list changes direction in IE11 as it already does elsewhere, with regression coverage if the relevant binding tests are found.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.