aurelhubert / aurelhubert/ahbottomnavigation

Calling setColoredModeColors() inside onTabSelectedListener() breaks ripple

Open
#411 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
3.8k
Forks
672
PR merge metrics
No merged PRs in 30d

Description

Calling `bottomNavigation.setColoredModeColors()` (or pretty much any other method from the AHBottomNavigation class) inside the `onTabSelectedListener()` sets the center of the color change ripple to the top left corner of the bottom navigation element. I'm suspecting that it has something to do with the `createItems()` method called at the end of all offending methods in `AHBottomNavigation.class`. Is there a way to set the color change ripple center after these methods are called so the ripple comes from the center of the icon? Thanks.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in AHBottomNavigation.class by tracing onTabSelectedListener(), setColoredModeColors(), and the createItems() calls at the end of the affected methods. Reproduce the issue by changing colors inside the listener and inspect how the ripple center is calculated. Done means the color-change ripple originates from the selected icon rather than the top-left corner.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.