aurelhubert / aurelhubert/ahbottomnavigation

Notification doesn't support RTL - badge is on right, not end

Open
#350 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
3.8k
Forks
672
PR merge metrics
No merged PRs in 30d

Description

![image](https://user-images.githubusercontent.com/4904335/39436208-45fec296-4c95-11e8-9459-5bb1cfe443aa.png)

(I've deleted the other two icons from the screenshot.)

I'm not 100% what the right behavior here is, but I think most things that were aligned to the right (e.g. the FAB) alight to the left when using an RTL locale (here, I'm using AR (XB) from https://developer.android.com/guide/topics/resources/pseudolocales).

However, the badge is aligned to the right still.

As far as I know, materials design doesn't mention these badges to go on the Bottom Navigation View, so there isn't any authority here as to what the "right" thing to do is. I think that it should align to the left. I feel like raising an issue is the bet place for that discussion!

Contributor guide

No contributing guide indexed for this repository

Research direction

No source file or test is named. Reproduce the Bottom Navigation badge behavior with the AR (XB) RTL locale, then inspect the badge positioning and determine the agreed end-of-layout behavior; done means the badge follows the chosen RTL alignment consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
design, internationalization, mobile
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.