aurelhubert / aurelhubert/ahbottomnavigation

Elevation issue

Open
#315 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
3.8k
Forks
672
PR merge metrics
No merged PRs in 30d

Description

Hello,
I have a problem with elevation with AhBottomNavigation, here is a final output where elavation is missing:
![screenshot_20180119-151630](https://user-images.githubusercontent.com/29424653/35154853-079e0c04-fd2c-11e7-9156-d30ee99b3874.png)

I have notice when i add a bottom margin, elevation is present but under bar:

![screenshot_20180119-151700](https://user-images.githubusercontent.com/29424653/35154880-1bee6a0a-fd2c-11e7-81df-7b0a0ff17b03.png)

here is a layout code:

`






`

and here is initializaion:
` mainBottomNavigation.defaultBackgroundColor = ContextCompat.getColor(this, R.color.colorPrimary)
mainBottomNavigation.accentColor = ContextCompat.getColor(this, R.color.bottomIconSelected)
mainBottomNavigation.inactiveColor = ContextCompat.getColor(this, R.color.bottomIconUnselected)
mainBottomNavigation.setOnTabSelectedListener(presenter::onMenuSelected)
val navigationAdapter = AHBottomNavigationAdapter(this, R.menu.bottom_menu)
navigationAdapter.setupWithBottomNavigation(mainBottomNavigation)
mainBottomNavigation.setOnNavigationPositionListener {
if (isBottomVisible != !mainBottomNavigation.isHidden){
isBottomVisible = !isBottomVisible
bottomBarListener?.invoke(mainBottomNavigation.isHidden)
}
}`

Here is a styles:

`
<!-- Customize your theme here. -->
<item name="colorPrimary">@color/colorPrimary</item>
<item name="colorPrimaryDark">@color/colorPrimaryDark</item>
<item name="colorAccent">@color/colorAccent</item>
<item name="android:windowBackground">@color/colorPrimaryDark</item>

<item name="colorControlHighlight">@color/bottomRipple</item>
`

I have miss something? Please provide any suggestions.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the report with the supplied CoordinatorLayout XML, BottomBarStyle, and mainBottomNavigation initialization. Compare the elevation with and without the reported bottom margin, and verify that the final layout shows elevation above the AHBottomNavigation bar without relying on the margin.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.