audacity / audacity/audacity

Low Quality Change pitch generates a short silence at the end of a selection

Open
#5,403 2 comments 0 reactions 1 assignee Claimed by @chinakov View on GitHub
AU3-bug bug Effects (EGATs) P2 PO Review regression
Dominant language
C++
Stars
18.4k
Forks
2.7k
Avg merge
3d 1h
Merged PRs (30d)
78

Description

### Bug description
Low Quality Change pitch generates an unwanted short silence at the end of a selection

a) this does **_not_** apply when using Change Pitch in High Quality mode
b) this **does** apply when applying the effect to a whole isolated clip
c) this **_does_** occur when applying the effect to a clip which abuts another clip on the right.

### Steps to reproduce
1. Generate a 30 second chirp
2. select from 10-15 seconds
3. Effect > Change Pitch (using Low Quality mode)
4. **Observe: at the end of the selection a short silence**
5. Undo
6. Run Change Pitch again in High Quality mode
7. Observe: no such silence at the end of the selection
8. Undo
9. Select the whole clip
10. Effect > Change Pitch (using Low Quality mode)
11. **Observe: at the end of the selection a short silence**

### Expected behavior
No such unwanted silence to be generated

### Actual behavior
![image](https://github.com/audacity/audacity/assets/50205984/ae113756-5146-42fb-95c1-ed75f9638ede)

![image](https://github.com/audacity/audacity/assets/50205984/b1f2b2c1-3d5e-412e-b1b4-c60dd7f6f0bd)

### Audacity Version
latest 3.4.0 beta: audacity-win-3.4.0-beta-20231020+0ec0d02-x64-msvc2022

### Operating system
Windows 10 - but assume allOS

### Additional context
This is a regression on 2.4.2 introduced in version 3.0.0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.