auchenberg / auchenberg/vscode-browser-preview

Feature: Support window.close()

Open
#56 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
4.4k
Forks
152
PR merge metrics
No merged PRs in 30d

Description

Under #40 you added support for window.open(), but if a script invokes window.close(), for example in response to a click on a "Proceed" button, the window doesn't disappear.

https://github.com/ChromeDevTools/devtools-protocol/issues/146#issuecomment-460563159 might be useful.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review issue #40 and its implementation of window.open() first, then follow the linked Chrome DevTools Protocol discussion for window.close(). The work is done when a script calling window.close(), such as one triggered by the Proceed button, causes the preview window to disappear.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop, web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.