atomiclabs / atomiclabs/hyperdex

Consider isolating Node.js from the render process

Open
#221 0 comments 0 reactions 0 assignees View on GitHub
low priority
Dominant language
JavaScript
Stars
151
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Currently an XSS attack could get access to the main system due to the render process having direct access to the Node.js process.

This is low priority, an XSS attack could still steal the users balances, there's no way to protect against that (apart from taking measures against XXS in the first place which we already have).

So this would just make an absolutely terrible situation slightly less terrible.

However it would limit the attack to within HyperDEX rather than the entire system, so it's worth considering.

We already have a strict CSP and all external input is escaped by React, so we are already pretty well protected against an XSS attack.

Original discussion in: https://github.com/lukechilds/hyperdex/issues/10

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the original discussion in issue 10 and tracing how the render process currently accesses Node.js. Define the process boundary and verify that an XSS attack can no longer reach the main system while the existing HyperDEX functionality remains usable.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js, react
Domain
security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.