atomashpolskiy / atomashpolskiy/rustface
Re-evaluate parallelization (Rayon)
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 436
- Forks
- 40
- PR merge metrics
- No merged PRs in 30d
Description
Seems lik the --no-default-features flag (which disables Rayon multiprocessing) actually leads to a serious speedup of detect(), from ~1000 ms to ~700 ms on the scientists.jpg image. Likely due to shaving off threading overhead. This is on a noisy dual core 2018 MBP, so YMMV.
I think larger images may benefit more from parallel processing, let's test that first. We may need to re-evaluate whether we want parallel processing on by default.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating detect() and the feature configuration behind --no-default-features, then benchmark scientists.jpg and larger images with and without Rayon. Compare the timings across image sizes and hardware conditions, and use those results to determine whether the default parallel-processing choice should change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- computer-vision, performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100