atom-community / atom-community/atom-script

Time execution output should not have .stdout class

Open
#1,448 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
730
Forks
264
PR merge metrics
No merged PRs in 30d

Description

When the 'Output the time it took to execute the script' option is enabled, the `[Finished in (...)s]` message is appended to the actual script output. Currently this final `pre` line also has the `.stdout` class set. I would suggest this is omitted, as the line does not contain actual stdout contents.

A direct advantage is this allows themes and other packages to differentiate between actual stdout contents and what was added by atom-script, and for instance provide a clear visual indication that the script has finished running.

An alternative solution would be to add a `execution-time` class explicitly to the line to make it stand out, but it this seems redundant and the message would still be incorrectly labeled as something that came from stdout.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.