atom-community / atom-community/atom-languageclient
Add tests for more server manager functions
- Dominant language
- TypeScript
- Stars
- 47
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Some of the [ServerManager](https://github.com/atom-community/atom-languageclient/blob/master/lib/server-manager.ts) functions do not have tests.
https://github.com/atom-community/atom-languageclient/blob/1c2b2cd22f74103d7d96bc0caf1e4b68d5866af7/test/auto-languageclient.test.ts#L95
- [x] getWorkspaceFolders -> #153
- [x] projectPathsChanged -> #153
- [ ] projectFilesChanged
- [x] projectPathToWorkspaceFolder -> #153
- [x] normalizedProjectPathToWorkspaceFolder -> #153
- [x] considerAdditionalPath -> #160
- [ ] startServer
- [ ] stopUnusedServers
- [ ] stopAllServers
- [ ] restartAllServers
- [ ] hasServerReachedRestartLimit
- [ ] stopServer
- [ ] exitServer
- [ ] terminate
Contributor guide
Research direction
Start with lib/server-manager.ts and the existing tests around test/auto-languageclient.test.ts#L95. Review the unchecked ServerManager functions listed in the issue and add coverage for them. Done means projectFilesChanged and each listed server lifecycle function has tests, with the test suite passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100