atlassian / atlassian/nucleus

Allow armv7l and multiple arch uploads for linux

Open
#79 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
420
Forks
100
PR merge metrics
No merged PRs in 30d

Description

Hello,

I need to allow uploads for an armv7l build (Raspberry) but nothing is uploading and no error is shown. The x64 arch file uploads successful.

I searched for a fix and found that armv7l files are ignored and the execution stops
https://github.com/atlassian/nucleus/blob/36117b029b513821960c35bf1d1b6e465ae66581/src/files/Positioner.ts#L76-L78

And only one type of arch can be uploaded, if I upload the armv7l build and after the x64 one, the last one is ignored. After some testing the issue seems to be here.
https://github.com/atlassian/nucleus/blob/36117b029b513821960c35bf1d1b6e465ae66581/src/db/BaseDriver.ts#L8

Instead of .deb should be 'amd64.deb', 'armhf.deb', 'i386.deb, the same should be for rpm.

I'l soon submit a PR with fixes for this issue

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/files/Positioner.ts around L76-L78 to trace why armv7l files are ignored, then inspect src/db/BaseDriver.ts around L8 for the single-architecture handling. Confirm the upload path accepts armv7l alongside x64 and preserves multiple Linux architecture packages, including the corresponding .deb and rpm names.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, linux, typescript
Domain
backend, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.