athityakumar / athityakumar/colorls

Can't list files with chinese characters on windows 10

Open
#316 18 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Ruby
Stars
5.1k
Forks
396
PR merge metrics
No merged PRs in 30d

Description

### Description

- Type of issue :
- [ ] Installation
- [ ] Font-related
- [ ] Feature request
- [x] Bug in existing feature
- [ ] Developer mode : Code quality / Tests / Documentation

Shows an error and doesn't list files when any file in the directory has chinese characters in it's name, for example
杨帆.pdf

Error
Invalid argument @ rb_file_s_lstat - D:/??.pdf

Windows 10
colorls 1.2.0
ruby 2.5.5p157 (2019-03-15 revision 67260) [x64-mingw32]

Contributor guide

Open the contributing guide

Research direction

No file or test is named. First reproduce the failure in colorls 1.2.0 on Windows 10 with a filename such as 杨帆.pdf, then trace the file-listing path and its handling of the displayed path. Done means directories containing Chinese-character filenames are listed without the rb_file_s_lstat invalid-argument error.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.