asyncapi / asyncapi/html-template
Request approval to fix SonarCloud workflow permission warnings
- Dominant language
- JavaScript
- Stars
- 93
- Forks
- 75
- Avg merge
- 6m
- Merged PRs (30d)
- 7
Description
Hi @derberg @fmvilas @magicmatatjahu ,
I noticed that the SonarCloud quality gate for this repository is currently
failing due to new security warnings related to GitHub Actions workflow
permissions.
SonarCloud reports the following issue on new code:
- “Move this write permission from workflow level to job level”
These warnings appear in non-centrally-managed workflow files
(e.g. `if-nodejs-release.yml`) and are marked as new issues affecting the
security rating.
I would like to work on fixing these warnings by:
- Moving `write` permissions from the workflow level to only the jobs
that actually require them
- Making no functional or behavioral changes to the workflows
Before proceeding, I wanted to ask for confirmation that this change is
acceptable and aligns with the project’s contribution process.
Happy to submit a PR once approved.
Thanks!
Contributor guide
Research direction
If approved, start by reviewing the SonarCloud warnings and the non-centrally-managed workflow example `if-nodejs-release.yml`. Identify which jobs actually need write permissions, move those permissions to job scope without changing behavior, and verify that the SonarCloud warnings are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd, security
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100