asyncapi / asyncapi/cli

[BUG] Unused dependency

Open
#2,183 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
272
Forks
375
Avg merge
3h 22m
Merged PRs (30d)
8

Description

### Describe the bug.

It looks to me like this:
https://github.com/asyncapi/cli/pull/1932/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R43 introduced a pinned version dependency on `@asyncapi/generator@3.0.1`. Which is also there in main: https://github.com/asyncapi/cli/blob/master/package.json#L43

But I can not find any explicit usages in code: https://github.com/search?q=repo%3Aasyncapi%2Fcli+generator-v2&type=code

It does however result in two resolved dependencies in the tree, where one is seemingly unused?

### Expected behavior

Only the needed/used dependencies are installed

### Screenshots

```
pnpm why @asyncapi/generator
@asyncapi/generator@3.0.1
└─┬ @asyncapi/cli@5.0.6
└── @our-package/common (devDependencies)

@asyncapi/generator@3.1.1
└─┬ @asyncapi/cli@5.0.6
└── @our-package/common (devDependencies)

Found 2 versions of @asyncapi/generator
---
pnpm why @asyncapi/generator
@asyncapi/generator@3.0.1
└─┬ @asyncapi/cli@6.0.0
└── @our-package/common (devDependencies)

@asyncapi/generator@3.1.1
└─┬ @asyncapi/cli@6.0.0
└── @our-package/common (devDependencies)

Found 2 versions of @asyncapi/generator
```

### How to Reproduce

Install `@asyncapi/cli`.
Check installed dependencies.

### 🖥️ Device Information [optional]

### 👀 Have you checked for similar open issues?

- [x] I checked and didn't find similar issue

### 🏢 Have you read the Contributing Guidelines?

- [x] I have read the [Contributing Guidelines](https://github.com/asyncapi/.github/blob/master/CONTRIBUTING.md)

### Are you willing to work on this issue ?

Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.