Merge PositionalEmbedding with Sinosoidal Positional Embedder
Open
enhancement
topic: modules
- Dominant language
- Python
- Stars
- 2.4k
- Forks
- 367
- PR merge metrics
- No merged PRs in 30d
Description
This embedding must be moved to `embedder` and if possible, mered with the current Sinosoidal position embedder, pls open an issue to record this TODO
_Originally posted by @ZhitingHu in https://github.com/asyml/texar/pull/182/commits/8a99af3472ca81c258020455c86eb0e16779bb0f_
Contributor guide
No contributing guide indexed for this repository
Research direction
No file or test is named. Start by locating PositionalEmbedding and the current sinusoidal position embedder, then inspect the embedder package and how both classes are used. Done means the embedding is in embedder and the two implementations are merged if their behavior can be unified; otherwise document why they remain separate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, tensorflow
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100