astropy / astropy/specutils

Add the warn_continuum_below_threshold checker to all the analysis functions where it's relevant

Open
#548 4 comments 0 reactions 0 assignees View on GitHub
analysis enhancement
Dominant language
Python
Stars
204
Forks
134
Avg merge
12h 55m
Merged PRs (30d)
1

Description

As per the plan in https://github.com/astropy/specutils/issues/535#issuecomment-541783378,
after #546 has been done, *if* there's not big performance penalties, the decorator implemented in #538 should be expanded to all the analysis functions that require continuum-subtracted input spectra.

Contributor guide

Open the contributing guide

Research direction

Read the plan in issue #535, especially comment 541783378, then review the implementation from issue #538 and the completed work in #546. Identify the analysis functions that require continuum-subtracted input spectra and assess the performance impact. Done means the checker is applied to all relevant functions without a significant performance penalty.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.