astropy / astropy/specutils

Have QuantityModel support spectral-equivalent inputs

Open
#350 1 comment 0 reactions 0 assignees View on GitHub
effort-high fitting
Dominant language
Python
Stars
204
Forks
134
Avg merge
12h 55m
Merged PRs (30d)
1

Description

Right now the `QuantityModel` (as output by the fitting machinery) only accepts inputs with the *same* units as the spectrum.spectral_axis that was used to create it. It would be nice if it also recognized spectral equivalencies - i.e., if you give a continuum model, say, a `GHz` quantity, it should know to convert it if the input to the model is `angstrom`, using the `spectral` equivalencies provided by astropy.

Contributor guide

Open the contributing guide

Research direction

Start with QuantityModel as produced by the fitting machinery and trace how it validates inputs against spectrum.spectral_axis units. Check the existing spectral-equivalencies behavior for a GHz input against an angstrom input, and consider the work done when those equivalent units are accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.