astropy / astropy/specutils

Have a heuristic utility function for "center" of a model

Open
#303 0 comments 0 reactions 0 assignees View on GitHub
enhancement fitting
Dominant language
Python
Stars
204
Forks
134
Avg merge
12h 55m
Merged PRs (30d)
1

Description

Prompted by https://github.com/astropy/specutils/pull/210#discussion_r214478583 : right now the "window" functionality of the fitting machinery assumes the model has a `center`. Many models don't have such a parameter - it goes by other names like `mu` or whatever. We should add a heuristic function to decide what the "center" is based on models we know we care about.

Longer-term it might be good for models to have a way to indicate that some parameters are location parameters, but that's an upstream problem.

Contributor guide

Open the contributing guide

Research direction

Start with the discussion in astropy/specutils#210 and trace the fitting machinery's window functionality to see how it currently assumes a model has a `center`. Define the supported model cases and a heuristic for alternate parameter names, with tests demonstrating the selected center for the models the project cares about.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.