astropy / astropy/specutils

sdss-v mwmVisit data loaders broken

Open
#1,182 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
204
Forks
135
Avg merge
12h 55m
Merged PRs (30d)
1

Description

The SDSS-V data loader for `mwmVisit` fails to load `mwmVisit` files that only have BOSS-extension data in them. It loads fine for `mwmVisit` files with only APOGEE-extension data. I think the issue is during metadata collection, it looks for info specific to certain extensions but not all. e.g. see https://github.com/astropy/specutils/blob/67bea40efb4e4a01672241123db6c225b3954d14/specutils/io/default_loaders/sdss_v.py#L589

We could either remove the metadata entirely as it's not strictly necessary to load the spectrum, or adjust this code. This is a blocker for https://github.com/sdss/sdss_solara/issues/9

Either I or relevant folks can fix, just creating an issue for tracking.

Contributor guide

Open the contributing guide

Research direction

Start in specutils/io/default_loaders/sdss_v.py around line 589 and compare metadata collection for BOSS-only and APOGEE-only mwmVisit files. Confirm the failure with a BOSS-extension-only file, then determine whether metadata can be removed or made extension-independent. Done means BOSS-only mwmVisit files load successfully without breaking APOGEE-only files.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.