astropy / astropy/specreduce

See if the WavelengthCalibration1D.refine_fit penalty function can be made more robust

Open
#288 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
69
Forks
43
Avg merge
4d 22h
Merged PRs (30d)
3

Description

@kbwestfall noticed that the penalty function used to refine a wavelength calibration solution in `WavelengthCalibration1d` may lead to situations where the fit is improved by finding solutions that exclude lines rather than improving the polynomial. We need to take a look at how to make the penalty function more robust.

https://github.com/astropy/specreduce/pull/265#discussion_r2308206285

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the WavelengthCalibration1D.refine_fit implementation and the linked pull-request discussion about the penalty function. Determine how to assess cases where the fit excludes lines instead of improving the polynomial; done means the penalty is more robust against that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
data
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.