astropy / astropy/specreduce

Horne extraction test for non-flat trace is unstable

Open
#247 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
69
Forks
43
Avg merge
4d 22h
Merged PRs (30d)
3

Description

The last `assert_quantity_allcose` in `test_horne_non_flat_trace` test checking that the Horne extraction from a flat trace equals the one from a non-flat trace fails occasionally. This seems to be rather rare and random issue, and difficult to reproduce, but it would be very good to understand whether this is a problem in the test design or Horne extraction itself. An easy fix would be to increase the assertion tolerances, but we shouldn't do this before we understand what is causing the discrepancy.

Contributor guide

Open the contributing guide

Research direction

Start with the test_horne_non_flat_trace test and its final assert_quantity_allcose assertion, then inspect the Horne extraction path it exercises. Run the test repeatedly to characterize the intermittent discrepancy and determine whether it comes from the test design or extraction; done means documenting the cause and adding a reliable fix or regression coverage without merely widening tolerances.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.