astropy / astropy/specreduce

TST: Add image test for display in fluxcal.py

Open
#204 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Jupyter Notebook
Stars
69
Forks
43
Avg merge
4d 22h
Merged PRs (30d)
3

Description

Currently, this block is not tested:

https://github.com/astropy/specreduce/blob/aa4ceabbfb69595ac58c2ff29a220aabe1e37f68/specreduce/fluxcal.py#L262

Since it is plotting, you might want to write a test where you compare the image, like how `astropy.visualization` does it. That would require additional CircleCI setup and a place to host the truth image(s).

Contributor guide

Open the contributing guide

Research direction

Read specreduce/fluxcal.py around line 262 and compare the approach with astropy.visualization image tests. Then inspect the CircleCI setup and determine where truth images would be hosted; done means the plotting block has a stable image-comparison test running in CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd, data-visualization, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.