astropy / astropy/specreduce

Simplify inputs to wavelength calibration 1d, allow frequency inputs in addition to wavelengths

Open
#181 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
69
Forks
43
Avg merge
4d 22h
Merged PRs (30d)
3

Description

Currently there are a variety of allowed input types for matched pixel and wavelengths - both can be an input quantity array, an input Q table with specific column names, a combination of table and column, or two separate one-column tables. I think this is a bit confusing, especially because it becomes the case where some parameters are only used if others are set, and we should allow only one input format. The decision of which one to allow (two arrays vs. table) should be standard across the package as well. I think that requiring two quantity arrays makes the most sense, since this avoids checking for specific column names and that the data type matches these column names.

Additionally, there are references in the code to matched pixel+frequency being allowed for the fit, but there are checks for the presence of specifically a 'wavelength' column, so this simplification of inputs should address this as well.

Contributor guide

Open the contributing guide

Research direction

No file, test, or entry point is named; start by locating the wavelength-calibration-1d input handling and the checks for a 'wavelength' column. Done means one accepted input format using two quantity arrays, with both wavelength and frequency inputs supported consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
data
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.