astropy / astropy/regions

Account for finite pixel size in PointPixelRegion.contains

Open
#474 7 comments 0 reactions 0 assignees View on GitHub
question shapes
Dominant language
Python
Stars
65
Forks
64
Avg merge
2d 13h
Merged PRs (30d)
4

Description

Currently the `PointPixelRegion.contains` method [always returns `False`](https://github.com/astropy/regions/blob/main/regions/shapes/point.py#L81). However this is not correct for the cases of sampled image data, because the size of the pixel is finite, namely `1 x 1 pix`. This mean the `.contains()` method should return true if a position is contained in the finite support of the pixel.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading regions/shapes/point.py at PointPixelRegion.contains, currently identified at line 81, and inspect the surrounding point-region behavior. The work is done when contains accounts for the finite 1 x 1 pixel support in sampled image data rather than always returning False.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.