astropy / astropy/pyvo

deprecation warnings from pyvo incorrectly indicate an Astropy issue

Open
#666 5 comments 0 reactions 0 assignees View on GitHub
enhancement infrastructure
Dominant language
Python
Stars
88
Forks
64
Avg merge
38m
Merged PRs (30d)
1

Description

The deprecated [decorator](https://github.com/astropy/pyvo/blob/e60ace98fcdb88f141ea3e9c22b4722e23e18031/pyvo/dal/vosi.py#L9) which is imported from astropy produces warnings that indicate that the deprecation comes from Astropy instead of pyvo.

Could the deprecation warnings be reworked so that they correctly indicate that the deprecation is in pyvo instead of astropy?

Perhaps the decorator could still be reused from astropy but adapted for pyvo. it [looks like](https://github.com/astropy/astropy/blob/7f259327a77787abe7caa1ac5b7103f39a7c4389/astropy/utils/decorators.py#L32) if you pass warning_type or pending_warning_type with custom pyvo classes it might resolve this issue.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with pyvo/dal/vosi.py and compare the imported decorator with astropy/utils/decorators.py, especially its warning_type and pending_warning_type handling. Trace how the deprecation warning is produced and confirm that the resulting warnings identify pyvo rather than Astropy; no test file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.