astropy / astropy/pyvo

Limited SIA radius?

Open
#650 1 comment 0 reactions 0 assignees View on GitHub
component: SIA question
Dominant language
Python
Stars
88
Forks
64
Avg merge
38m
Merged PRs (30d)
1

Description

I don't find any such limit in the spec (https://www.ivoa.net/documents/SIA/20151223/REC-SIA-2.0-20151223.html), is this really necessary?
(My naive use case was to see if a collection had any data in it, so wanted to do as big of a search as possible, very naive approach, but still, I suppose (almost) all sky queries should be allowed at the library level?

```
334 if radius <= 0 * u.deg or radius.to(u.deg) > 90 * u.deg:
```

cc @msdemlei

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the radius validation shown around line 334 and compare its upper-bound behavior with the linked SIA 2.0 specification. Determine whether all-sky queries should be accepted at the library level, then identify or add coverage for zero, 90-degree, and larger-radius inputs; done means the behavior matches the agreed interpretation of the specification.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.