astropy / astropy/halotools

Review API of new satellite rotations module

Open
#907 1 comment 0 reactions 2 assignees Claimed by @aphearin View on GitHub
code-review request utils
Dominant language
Python
Stars
120
Forks
70
PR merge metrics
No merged PRs in 30d

Description

Ensure that the current API of the satellite rotations module introduced in PR #905 is the most useful formulation for intrinsic alignment modeling, and also synthetic satellite/subhalo additions/transfer.

In particular, there should be consistency enforced between these functions and `mock_observables.velocity_decomposition` and `catalog_analysis_helpers.relative_positions_and_velocities`, since there is redundancy in those implementations.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.